Repository navigation
harness setup - #536
harness setup#536
Conversation
…ns and verificationas to make pre-commit checks mandatory
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
… at EOF package.json
parfeon
left a comment
There was a problem hiding this comment.
LGTM (with few clarification questions)
| @@ -0,0 +1,16 @@ | |||
| #!/bin/bash | |||
| # Stop hook. Don't let the agent finish with a failing type check. Keep it under ~30 s. | |||
There was a problem hiding this comment.
A bit confusing statement especially if we skip check when node_modules is missing and we don't force user to run npm ci.
|
|
||
| ## Commands | ||
| - Install: `npm install`, as `run-tests.yml` does. Use Node 22 or 24, the CI matrix. Mocha fails at startup on Node 26; that's environmental, not an SDK bug. | ||
| - Build (no keys needed): `npm run build:node` (tsc → `lib/` + aggregated `lib/types/index.d.ts`) · `npm run build:web` (rollup → `dist/web/`). Run `build:node` before the `release` or `node` suite. |
There was a problem hiding this comment.
There is actually no need to run build:node before release because release bot does run npm run build before committing change logs. But in case if something has been changed after - then yes.
| | [sdk-specifications](https://github.com/pubnub/sdk-specifications) | `test/specs` | `npm run test:contract:prepare` (rm + shallow clone of `master`) | | ||
| | [service-contract-mock](https://github.com/pubnub/service-contract-mock) | `dist/contract` | `npm run contract:refresh` (rm + clone + npm install) | |
There was a problem hiding this comment.
I would move these addresses into .env file instead of hardcoding them here.
There was a problem hiding this comment.
Those are the public clone URLs already in test:contract:prepare and contract:refresh, not secrets. .env files are gitignored and blocked for agents, so moving them there would hide the setup this skill is meant to document.
…when src change - address review comment
docs: repository harness setup files